Bonsai Tries: Respect account deletion across transacitons #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated side of a bonsaiValue may legitalately be null, indicatinga dalete. In those cases optionals should contain empty. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
In a block if another account is deleted vs self destruct the sstore operation could get an incorrect original value, and if the new write is the same as the value before delete a SLOAD cost will mistakenly be applied. Found in mainnet block 11905274 for account 0x7f150bd6f54c40a34d7c3d5e9f56. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
Looks good to me, would there be a way to have a test to back it up? |
shemnon
added a commit
that referenced
this pull request
Feb 26, 2021
When in bonsai mode, if inside one block an account is deleted via self destruct and then the account is re-created the latter sstore operation reports the last SSTORE value prior to self destruct. Thus if the new write is the same as the value before delete a non-updating gas cost will mistakenly be applied. Thus we first check accountWasDeleted when reading original slot values. Found in mainnet block 11905274 for account 0x7f150bd6f54c40a34d7c3d5e9f56. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
RichardH92
pushed a commit
to RichardH92/besu
that referenced
this pull request
Mar 29, 2021
…er#1952) When in bonsai mode, if inside one block an account is deleted via self destruct and then the account is re-created the latter sstore operation reports the last SSTORE value prior to self destruct. Thus if the new write is the same as the value before delete a non-updating gas cost will mistakenly be applied. Thus we first check accountWasDeleted when reading original slot values. Found in mainnet block 11905274 for account 0x7f150bd6f54c40a34d7c3d5e9f56. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…er#1952) When in bonsai mode, if inside one block an account is deleted via self destruct and then the account is re-created the latter sstore operation reports the last SSTORE value prior to self destruct. Thus if the new write is the same as the value before delete a non-updating gas cost will mistakenly be applied. Thus we first check accountWasDeleted when reading original slot values. Found in mainnet block 11905274 for account 0x7f150bd6f54c40a34d7c3d5e9f56. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In a block if another account is deleted vs self destruct the sstore
operation could get an incorrect original value, and if the new write is
the same as the value before delete a SLOAD cost will mistakenly be
applied. Found in mainnet block 11905274 for account
0x7f150bd6f54c40a34d7c3d5e9f56.
Fixed Issue(s)
Changelog