Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoQuorum private tx use zero gas (mining) #1924

Merged
merged 8 commits into from
Feb 18, 2021

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 17, 2021

gas used zero for GoQuorum private tx

Changelog

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla requested a review from pinges February 17, 2021 23:25
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla marked this pull request as ready for review February 18, 2021 04:47
@macfarla macfarla changed the title DRAFT GoQuorum private tx use zero gas (mining) GoQuorum private tx use zero gas (mining) Feb 18, 2021
@@ -285,7 +289,7 @@ private boolean transactionTooLargeForBlock(
default:
throw new IllegalStateException(
String.format(
"Developer error. Supported transaction type %s deoesn't have a block gas budget calculator",
"Developer error. Supported transaction type %s doesn't have a block gas budget calculator",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@macfarla macfarla merged commit 343907a into hyperledger:master Feb 18, 2021
@macfarla macfarla deleted the goquorum-miner branch February 18, 2021 22:06
RichardH92 pushed a commit to RichardH92/besu that referenced this pull request Mar 29, 2021
* set gas used to zero for goQuorum private tx

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Co-authored-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* set gas used to zero for goQuorum private tx

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Co-authored-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants