Cope with clients that don't implement EIP-706 #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all clients implement EIP-706, even though they may advertise a version 5 in the hello packet. To cope with this when we have a snappy decompression error if we have never succeeded in decompression turn off snappy compression. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
RichardH92
pushed a commit
to RichardH92/besu
that referenced
this pull request
Mar 29, 2021
Not all clients implement EIP-706, even though they may advertise a version 5 in the hello packet. To cope with this if we are expecting compression but haven't had a compressed message yet and a new message fails to decompress we turn off compression and try again. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Not all clients implement EIP-706, even though they may advertise a version 5 in the hello packet. To cope with this if we are expecting compression but haven't had a compressed message yet and a new message fails to decompress we turn off compression and try again. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all clients implement EIP-706, even though they may advertise a
version 5 in the hello packet. To cope with this when we have a snappy
decompression error if we have never succeeded in decompression turn off
snappy compression.
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
PR description
Fixed Issue(s)
Changelog