Add 2/3n Commit count for IBFT blocks #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
added 6 commits
February 11, 2021 16:47
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
reviewed
Feb 12, 2021
config/src/main/java/org/hyperledger/besu/config/IbftLegacyConfigOptions.java
Show resolved
Hide resolved
config/src/main/java/org/hyperledger/besu/config/IbftLegacyConfigOptions.java
Show resolved
Hide resolved
added 2 commits
February 17, 2021 09:37
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
approved these changes
Feb 17, 2021
added 2 commits
February 17, 2021 16:41
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
RichardH92
pushed a commit
to RichardH92/besu
that referenced
this pull request
Mar 29, 2021
This allows Besu to interop with an Quorum IBFT-1 network which has been updated to use a 2/3 validator threshold, rather than 2F+1. Signed-off-by: Trent Mohay <trent.mohay@consensys.net> Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
This allows Besu to interop with an Quorum IBFT-1 network which has been updated to use a 2/3 validator threshold, rather than 2F+1. Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Quorum can configure their IBFT implementation to change from a 2F+1 to 2n/3 threshold (as set in the genesis file).
In order to ensure Besu can interop with these networks (as a listener, not validator), it is important that this change
be supported in blockheader validation.
Fixed Issue(s)
Changelog