Remove some validation from QBFT block header rules #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
…tion Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
reviewed
Feb 3, 2021
...c/main/java/org/hyperledger/besu/consensus/qbft/QbftBlockHeaderValidationRulesetFactory.java
Show resolved
Hide resolved
jframe
reviewed
Feb 3, 2021
...c/main/java/org/hyperledger/besu/consensus/qbft/QbftBlockHeaderValidationRulesetFactory.java
Show resolved
Hide resolved
added 4 commits
February 4, 2021 12:40
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
reviewed
Feb 5, 2021
...st/java/org/hyperledger/besu/consensus/qbft/QbftBlockHeaderValidationRulesetFactoryTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/hyperledger/besu/consensus/qbft/QbftBlockHeaderValidationRulesetFactoryTest.java
Outdated
Show resolved
Hide resolved
added 7 commits
February 5, 2021 12:03
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
…tion Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
…tion Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
…tion Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
davemec
pushed a commit
to davemec/besu
that referenced
this pull request
Feb 8, 2021
QBFT no longer validates all fields of the block header (eg nonce mixhash), as these have no bearing on the safety model of the protocol. Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
RichardH92
pushed a commit
to RichardH92/besu
that referenced
this pull request
Mar 29, 2021
QBFT no longer validates all fields of the block header (eg nonce mixhash), as these have no bearing on the safety model of the protocol. Signed-off-by: Trent Mohay <trent.mohay@consensys.net> Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
QBFT no longer validates all fields of the block header (eg nonce mixhash), as these have no bearing on the safety model of the protocol. Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trent Mohay trent.mohay@consensys.net
PR description
Fixed Issue(s)
Changelog