Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add JSON-RPC method to call /storeraw on GoQuorum enclave #1859

Merged
merged 20 commits into from
Feb 8, 2021
Merged

add JSON-RPC method to call /storeraw on GoQuorum enclave #1859

merged 20 commits into from
Feb 8, 2021

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 1, 2021 •
edited
Loading

PR description

override existing JSON-RPC method: priv_distributeRawTransaction which is a proxy to Tessera's /storeraw - and the factory chooses which implementation to create, depending on whether go-quorum mode is enabled.

/storeraw is required to process GoQuorum private transactions via EthSigner (analogous to priv_distributeRawTransaction for Orion)

Fixed Issue(s)

refs https://github.com/ConsenSys/protocol-misc/issues/256

Changelog

{
    "jsonrpc": "2.0",
    "method": "goquorum_storeRaw",
    "params": [
        "tQEmN0d/xXJZs5OMgl8QVBIyYxu1XubAKehsSYbcOjbxai+QJQpEOs6ghrYAZizLtnM4EJdMyVeVrxO3cA9JJA=="
    ],
    "id": 1
}

Gives result:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": "aC4t8i1td8+JWL31qNaV9i1rVc6gRwdPspRJhGTz4CL92MI7by9K/gvkwrtBc7BazNw3Yyu6fuDWs1JUGvEKjA=="
}

@macfarla
added storeraw to goQuorum enclave
d759607 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
formatting
5048045 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla requested a review from pinges February 1, 2021 01:29
@macfarla
Merge branch 'master' into goquorum-store-raw
088000c
@macfarla
Merge branch 'master' of https://github.com/hyperledger/besu into goq…
d38191c 
…uorum-store-raw
@macfarla
Merge branch 'goquorum-store-raw' of github.com:macfarla/besu into go…
64fa01a 
…quorum-store-raw
@macfarla
removed from key from request
5dafd10 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
Merge branch 'master' of https://github.com/hyperledger/besu into goq…
703c50e 
…uorum-store-raw
@macfarla
Merge branch 'master' of https://github.com/hyperledger/besu into goq…
8024494 
…uorum-store-raw
@macfarla
removed unused variable
c0ec6c7 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
status 200
d084b94 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
added GoQuorumStoreRawPrivateTransaction that can send a payload to T…
e0c5b9f 
…essera for storing

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla changed the title add /storeraw endpoint to GoQuorum enclave add JSON-RPC method to call /storeraw on GoQuorum enclave Feb 3, 2021
@macfarla
use same JSON-RPC method name rather than creating a new one
e597f05 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
removed unused RPC method name
02be030 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
finals
240ded3 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
don't need an order
8c06d7f 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
moved GoQuorumDistributeTx JSON-RPC to GoQuorumJsonRpcPrivacyMethods …
b1a0b9b 
…group

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
pinges
pinges approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another comment!
Would be nice if we could make sure that the right distribute RPC is used when both, PRIV and GOQUORUM RPCs are enabled!

...in/java/org/hyperledger/besu/ethereum/api/jsonrpc/methods/PrivacyApiGroupJsonRpcMethods.java Outdated
final String methodName = rpcMethod.getName();
if (methodName.equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
return rpcMethod;
} else if (methodName.equals(RpcMethod.PRIV_DISTRIBUTE_RAW_TRANSACTION.getMethodName())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be removed now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite

@macfarla
Merge branch 'master' of https://github.com/hyperledger/besu into goq…
11aa14c 
…uorum-store-raw
@macfarla
have a separate RPC call for goquorum_storeraw
ce5880d 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
rename
06f4768 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
Copy link
Contributor Author

macfarla commented Feb 5, 2021

I've added another comment!
Would be nice if we could make sure that the right distribute RPC is used when both, PRIV and GOQUORUM RPCs are enabled!

to achieve this I have given them different method names

@macfarla macfarla closed this Feb 8, 2021
@macfarla macfarla deleted the goquorum-store-raw branch February 8, 2021 00:03
@macfarla macfarla restored the goquorum-store-raw branch February 8, 2021 00:15
@macfarla macfarla reopened this Feb 8, 2021
@macfarla macfarla merged commit 1de067b into hyperledger:master Feb 8, 2021
@macfarla macfarla deleted the goquorum-store-raw branch February 8, 2021 00:44
davemec pushed a commit to davemec/besu that referenced this pull request Feb 8, 2021
@macfarla
add JSON-RPC method to call /storeraw on GoQuorum enclave (hyperledge…
c9480bc 
…r#1859)

* added GoQuorumStoreRawPrivateTransaction that can send a payload to Tessera for storing

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla mentioned this pull request Feb 10, 2021
Merged
1 task
@MadelineMurray MadelineMurray mentioned this pull request Feb 15, 2021
Closed
RichardH92 pushed a commit to RichardH92/besu that referenced this pull request Mar 29, 2021
@macfarla @RichardH92
add JSON-RPC method to call /storeraw on GoQuorum enclave (hyperledge…
8704ba5 
…r#1859)

* added GoQuorumStoreRawPrivateTransaction that can send a payload to Tessera for storing

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Richard Hart <richardhart92@gmail.com>
@vmichalik vmichalik mentioned this pull request Jun 25, 2021
Closed
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
add JSON-RPC method to call /storeraw on GoQuorum enclave (hyperledge…
91a88e6 
…r#1859)

* added GoQuorumStoreRawPrivateTransaction that can send a payload to Tessera for storing

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinges pinges pinges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @pinges