Multi-Tenancy: Do not specify a public key anymore when requesting a … #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…payload from Orion, so all private keys are tried to decrypt the encrypted payload. Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
usmansaleem
reviewed
Nov 13, 2019
...va/org/hyperledger/besu/ethereum/mainnet/precompiles/privacy/PrivacyPrecompiledContract.java
Outdated
Show resolved
Hide resolved
usmansaleem
reviewed
Nov 13, 2019
| @@ -94,8 +94,7 @@ public String sendToOrion(final PrivateTransaction privateTransaction) throws Ex | |||
| } | |||
| } | |||
|
|
|||
| public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction) | |||
| throws Exception { | |||
| public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction) { | |||
There was a problem hiding this comment.
why did you took Exception out? Is this method only throwing runtime exceptions?
There was a problem hiding this comment.
later on we are catching a blanket Exception, should we change that to RuntimeException instead?
usmansaleem
reviewed
Nov 13, 2019
| @@ -61,7 +61,7 @@ dependencyManagement { | |||
| dependency 'org.apache.tuweni:tuweni-crypto:0.9.0' | |||
| dependency 'org.apache.tuweni:tuweni-toml:0.9.0' | |||
|
|
|||
| dependency 'net.consensys:orion:1.3.2' | |||
| dependency 'net.consensys:orion:1.5.0-SNAPSHOT' | |||
There was a problem hiding this comment.
Ideally we should bind to a release version of Orion from Besu. Otherwise, it will be highly prone to break (I think)
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…payload from Orion, so all private keys are tried to decrypt the encrypted payload.
Signed-off-by: Stefan Pingel stefan.pingel@consensys.net