Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use a external JWT public key in authenticated APIs #183

Merged
merged 42 commits into from
Nov 17, 2019
Merged

Allow use a external JWT public key in authenticated APIs #183

merged 42 commits into from
Nov 17, 2019

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Nov 12, 2019

PR description

This adds support for using RPC authentication with JWTs that are created externally to Besu.

  • Adds two new configuration options rpc-http-authentication-public-key-file and rpc-ws-authentication-public-key-file to specify the public key use to validate the JWT
  • When the JWT public key is specified the login endpoint is disabled

Fixed Issue(s)

jframe added 19 commits November 8, 2019 15:40
@jframe
allow verification of externally signed jwt
d333278 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
move jwt configuration out of the auth service so it can be tested
943f0d1 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
jwt auth options ut
4543681 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
add file headers
778a6c5 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
increase generated key size to 2048 as recommended in the jwt rfc whe…
22066b6 
…n using rsa

Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
disable login if external jwt public key is used
a55d2ea 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Merge branch 'master' into external_jwt
c0e7c20
@jframe
handle JWT auth without credentials file
5708c08 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Only allow Auth service to be enabled if auth is enabled. Fixes the ATs
a55558c 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
http rpc JWT external public key ATs
9d24f8d 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
ws rpc JWT external public key ATs
44874a0 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
refactor login ATs
1d770b7 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
spotless
4c3b89a 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Fix compile error
c769ac3 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
final
0800233 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
change besu CLI so that ws can handle JWT auth without credentials file
77f749f 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
revert unneeded change
6b9b80f 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
update command line help
d27c814 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
additional besu command uts
b27f140 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
PR changes: rename AT var
4e221aa 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Fail JWT if expiry claim doesn't exist
c47b0a7 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
use pem file format
a18ccb8 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
handle invalid pem file format
4b287d9 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
update cli description to mention file is in pem format
7584013 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
spotless
014d2fe 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
additional unit tests
88631ad 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
default charset warning
bf29286 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe jframe marked this pull request as ready for review November 14, 2019 07:19
@jframe
Merge branch 'master' into external_jwt
e1dc25a
@jframe
PR changes: simplify AT authenticated node creation
3e4dd66 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
PR changes: split failure AT tests out into separate tests
7e4351a 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Merge branch 'external_jwt' of github.com:jframe/besu into external_jwt
5e1d9ed
@jframe
fix closing of pem reading file stream
e13b9db 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
fix closing of pem reading file stream
c4caf32 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
finals
e3154f1 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@hyperledger hyperledger deleted a comment from lgtm-com bot Nov 15, 2019
@hyperledger hyperledger deleted a comment from lgtm-com bot Nov 15, 2019
@jframe
PR changes for http login AT
0b98878 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
PR changes for ws login AT
eef9610 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
compile error
6eab286 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
add jwt into the cli options
80deef5 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
remove unnecessary capitalisation in cli description
f3aaf7d 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
spotless
19fedcf 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
update the cli options when using process runner in ATs
08fb77b 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe jframe merged commit 8951dd6 into hyperledger:master Nov 17, 2019
@jframe jframe deleted the external_jwt branch November 17, 2019 23:18
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
@jframe @edwardmack
Allow use a external JWT public key in authenticated APIs (hyperledge…
d354cc3 
…r#183)

Signed-off-by: Jason Frame <jasonwframe@gmail.com>
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
@jframe @edwardmack
Allow use a external JWT public key in authenticated APIs (hyperledge…
55c548b 
…r#183)

Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: edwardmack <ed@edwardmack.com>
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
@djrtwo
Merge pull request hyperledger#183 from mkalinin/engine-api-eth-subset
d4300c0 
Engine API: define a subset of exposing eth methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjHare CjHare CjHare left review comments

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jframe @lucassaldanha @CjHare