Re-introduce the spurious integration tests #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
reviewed
Jan 20, 2021
| } | ||
|
|
||
| @Test | ||
| public void badlyFormedRlpDoesNotPreventOngoingIbftOperation() { |
There was a problem hiding this comment.
rename IbftOperation to BftOperation
| } | ||
|
|
||
| @Test | ||
| public void messageWithIllegalMessageCodeAreDiscardedAndDoNotPreventOngoingIbftOperation() { |
There was a problem hiding this comment.
rename IbftOperation to BftOperation
| } | ||
|
|
||
| @Test | ||
| public void preparesWithMisMatchedDigestAreNotRepondedTo() { |
There was a problem hiding this comment.
typo Reponded should be Responded
added 2 commits
January 20, 2021 14:46
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
approved these changes
Jan 20, 2021
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trent Mohay trent.mohay@consensys.net
PR description
IBFT2 Integration tests proving system behaviour under spurious input have been ported to QBFT, and refactored for differences in business logic.
Fixed Issue(s)
N/A
Changelog
N/A