Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Reject Local Transactions Below Gas Minimum #1743

Merged
merged 10 commits into from
Jan 5, 2021
Merged

Don't Reject Local Transactions Below Gas Minimum #1743

merged 10 commits into from
Jan 5, 2021

Conversation

RatanRSur
Copy link
Contributor

@RatanRSur RatanRSur commented Jan 4, 2021 •
edited
Loading

Fixed Issue(s)

fixes #1480

Changelog

@RatanRSur
don't reject local transactions
0fd296b 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur
remove transaction pool configuration
41db197 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur
spotless
48ec0ab 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur
Revert "remove transaction pool configuration"
54b20c8 
This reverts commit 41db197.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur
add back excessive gas price blocking
392c2da 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur RatanRSur force-pushed the local-transaction-min-gas-price branch from 21ecf23 to 392c2da Compare January 4, 2021 21:53
@RatanRSur RatanRSur changed the title local transaction min gas price Don't Reject Local Transactions Below Gas Minimum Jan 4, 2021
@RatanRSur
changelog
1966416 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur RatanRSur marked this pull request as ready for review January 4, 2021 22:31
@RatanRSur RatanRSur requested a review from AbdelStark January 4, 2021 22:31
shemnon
shemnon approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does --min-gas-price still do anything after this? Is it a filter in mining TX selection?

shemnon
shemnon reviewed Jan 4, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@RatanRSur
Copy link
Contributor Author

Yup, it still rejects gossiped transactions.

@RatanRSur
link issue
5afb898 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur
fix link
3a775c8 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
@RatanRSur RatanRSur enabled auto-merge (squash) January 5, 2021 01:16
@RatanRSur RatanRSur merged commit 318a77f into hyperledger:master Jan 5, 2021
@antonydenyer antonydenyer mentioned this pull request Feb 10, 2022
Merged
1 task
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@RatanRSur @eum602
Don't Reject Local Transactions Below Gas Minimum (hyperledger#1743)
33a23cc 
We don't want to reject our own transactions.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

@AbdelStark AbdelStark Awaiting requested review from AbdelStark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove --min-gas-price's Influence on Local Transactions
2 participants
@RatanRSur @shemnon