EIP-2930: Access List Transactions #1712

RatanRSur · 2020-12-15T17:04:43Z

PR description

https://eips.ethereum.org/EIPS/eip-2930

Fixed Issue(s)

fixes #1504

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

…ansaction-type-refactor

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

…ke-2

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

… logic Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur · 2021-01-28T01:57:17Z

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/query/BlockchainQueriesTest.java

@@ -400,7 +400,7 @@ public void getOmmerByBlockHashAndIndexShouldReturnEmptyWhenIndexIsOutOfRange()

  @Test
  public void getOmmerByBlockHashAndIndexShouldReturnExpectedOmmerHeader() {
-    final BlockchainWithData data = setupBlockchain(3);
+    final BlockchainWithData data = setupBlockchain(4);


Since BlockDataGenerator changed, the blocks these tests tested had an empty ommer list. I bumped up the number of blocks to get a block with a non empty ommer list.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur · 2021-01-28T02:03:51Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/BodyValidation.java

+                    RLP.encode(
+                        rlpOutput ->
+                            TransactionRLPEncoder.encodeForTransactionTrie(
+                                transactions.get(i), rlpOutput))));


Because i had to be final

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur · 2021-01-28T02:10:49Z

besu/src/test/java/org/hyperledger/besu/PrivacyReorgTest.java

-    assertPrivateStateRoot(
-        privateStateRootResolver, blockchain, STATE_ROOT_AFTER_TRANSACTION_APPENDED_TO_EMPTY_STATE);


@lucassaldanha does this make sense? We're testing that the state root hash is EMPTY_ROOT_HASH still.

I think we might need to take a look at this. My understanding is that at the end, we are adding a 3rd block to the new chain, and that the block contains a PMT.Therefore, I would expect the private state root hash to be different from the empty state root hash (assuming this private tx in the 3rd block was processed and altered the state).

I'll ask someone from the team to take a look at it.

Ok cool, I merged because it had bugfixes important for 1559 but let me know if there's anything more that needs to be done with the test.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

…-2930

AbdelStark

Looks good to me. Left some minor comments

AbdelStark · 2021-02-01T14:37:37Z

besu/src/test/java/org/hyperledger/besu/PrivacyReorgTest.java

@@ -80,7 +80,6 @@
 import org.junit.rules.TemporaryFolder;

 @SuppressWarnings("rawtypes")
-// todo request lucas look at this pr


did you get some feedback ?

I did on that iteration. I'll ping him again for this one. 👍

AbdelStark · 2021-02-01T14:39:41Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/AccessList.java

+
+import org.apache.tuweni.bytes.Bytes32;
+
+public class AccessList extends ArrayList<Map.Entry<Address, List<Bytes32>>> {


Do we have some practices guidelines around using inheritance rather than composition/aggregation ?

The reason I did it this way was because I was really looking to do a type alias but java doesn't have them. This was the closest analog.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

…-2930

https://eips.ethereum.org/EIPS/eip-2930 Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur · 2021-02-09T17:29:53Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/vm/MessageFrame.java

+    // the warmed up addresses will always be a superset of the address keys in the warmed up
+    // storage so we can do both warm ups in one pass
+    accessListWarmAddresses
+        .parallelStream()
+        .forEach(
+            address ->
+                Optional.ofNullable(worldState.get(address))
+                    .ifPresent(
+                        account ->
+                            warmedUpStorage
+                                .get(address)
+                                .parallelStream()
+                                .forEach(
+                                    storageKeyBytes ->
+                                        account.getStorageValue(
+                                            UInt256.fromBytes(storageKeyBytes)))));


@shemnon What are your thoughts on this? Pure rocksdb caching. Should we consider explicit caching for just the access list entries?

https://eips.ethereum.org/EIPS/eip-2930 Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com> (cherry picked from commit 39b2c6e) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

https://eips.ethereum.org/EIPS/eip-2930 Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur added 30 commits December 12, 2020 17:41

first pass at removing AcceptedTypes

26cea0e

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

add transaction type stuff to transaction

2f4929a

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

rlp decoder/encoder changes

ffcc704

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

mainly test changes

64d92be

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

spotless

f3496bb

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fix tests

ecc4957

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

better error message and fix integration test

7e88e78

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

spotless

1d8292c

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

actually fix integration test this time

fff211d

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

some acceptance test fixes

9983c7e

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Merge branch 'master' of github.com:hyperledger/besu into eip-1559-tr…

461352e

…ansaction-type-refactor

bring over some eip-2930 stuff

3a37559

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

access list class

9833a38

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

bring accesListSigningMessage over

08d6eae

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

get to the point where the signature fails

5e9b036

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Merge branch 'master' of github.com:hyperledger/besu into eip-2930-ta…

bc4bc16

…ke-2

remove get

118b1f7

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

signature encoding/decoding

5939829

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

plugin-hash and spotless

adaf71f

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

wire access list through to message frame and calculate gas costs

b92914b

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

remove todo

505f3fe

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

enable support for access lists in berlin

45e7358

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Merge branch 'master' of github.com:hyperledger/besu into eip-2930

41391bc

rename intrinsic gas cost method and optimize accessed state gas cost…

420a918

… logic Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fix MainnetTransactionValidatorTest

6f11e7f

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fix NPE in DefaultPrivacyControllerTest

67718d9

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

rename

67e584d

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

actually warm everything up

1f36f8e

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

renames

f7a5763

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

remove todo

28661b8

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur added 3 commits January 27, 2021 10:22

fix tests that brittly rely on block data generator

31cc131

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fix brittle reorg test

1ea2fea

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

"fix" PrivacyReorgTest

221bf03

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur commented Jan 28, 2021

View reviewed changes

RatanRSur added 4 commits January 27, 2021 20:00

remove @JsonIgnore

da33fcc

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

rename

1f78dd9

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

rename rlpInput

2d13848

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

add check back

e5a69db

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur commented Jan 28, 2021

View reviewed changes

RatanRSur added 2 commits January 27, 2021 20:06

delete files from tests

81c6e8a

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

spotless

3f76d51

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur commented Jan 28, 2021

View reviewed changes

another deletion

f9f0663

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur changed the title ~~eip 2930~~ EIP-2930: Access List Transactions Jan 28, 2021

RatanRSur marked this pull request as ready for review January 28, 2021 02:33

Merge branch 'master' of https://github.com/hyperledger/besu into eip…

3662a2d

…-2930

AbdelStark approved these changes Feb 1, 2021

View reviewed changes

RatanRSur added 3 commits February 1, 2021 08:53

cleanup

0e8bd33

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

cleanup

74a3574

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Merge branch 'master' of https://github.com/hyperledger/besu into eip…

4e9b625

…-2930

RatanRSur enabled auto-merge (squash) February 1, 2021 17:49

Merge branch 'master' into eip-2930

f8885d8

RatanRSur merged commit 39b2c6e into hyperledger:master Feb 1, 2021

davemec pushed a commit to davemec/besu that referenced this pull request Feb 8, 2021

EIP-2930: Access List Transactions (hyperledger#1712)

2ba973e

https://eips.ethereum.org/EIPS/eip-2930 Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur commented Feb 9, 2021

View reviewed changes

shemnon mentioned this pull request Feb 9, 2021

Cherry picks from master for RC2 #1895

Merged

1 task

alexandratran mentioned this pull request Jun 15, 2021

EIP-2930 Add transaction types page hyperledger/besu-docs#737

Closed

4 tasks

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

EIP-2930: Access List Transactions (hyperledger#1712)

3737617

https://eips.ethereum.org/EIPS/eip-2930 Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-2930: Access List Transactions #1712

EIP-2930: Access List Transactions #1712

RatanRSur commented Dec 15, 2020 •

edited

Loading

RatanRSur Jan 28, 2021

RatanRSur Jan 28, 2021 •

edited

Loading

RatanRSur Jan 28, 2021

lucassaldanha Feb 1, 2021

RatanRSur Feb 2, 2021

AbdelStark left a comment

AbdelStark Feb 1, 2021

RatanRSur Feb 1, 2021

AbdelStark Feb 1, 2021

RatanRSur Feb 1, 2021

RatanRSur Feb 9, 2021

		assertPrivateStateRoot(
		privateStateRootResolver, blockchain, STATE_ROOT_AFTER_TRANSACTION_APPENDED_TO_EMPTY_STATE);


		import org.apache.tuweni.bytes.Bytes32;

		public class AccessList extends ArrayList<Map.Entry<Address, List<Bytes32>>> {

EIP-2930: Access List Transactions #1712

EIP-2930: Access List Transactions #1712

Conversation

RatanRSur commented Dec 15, 2020 • edited Loading

PR description

Fixed Issue(s)

Changelog

Choose a reason for hiding this comment

RatanRSur Jan 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AbdelStark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RatanRSur commented Dec 15, 2020 •

edited

Loading

RatanRSur Jan 28, 2021 •

edited

Loading