-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gasPrice when this field is present (eth_estimateGas) #1636
Merged
matkt
merged 10 commits into
hyperledger:master
from
matkt:fix_eth_estimate_with_gas_price
Dec 7, 2020
Merged
Use gasPrice when this field is present (eth_estimateGas) #1636
matkt
merged 10 commits into
hyperledger:master
from
matkt:fix_eth_estimate_with_gas_price
Dec 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
This was
linked to
issues
Dec 3, 2020
shemnon
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need docs changed to update the json rpc parameters.
shemnon
added
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Dec 4, 2020
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
bgravenorst
removed
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
This PR changes several things related to the
eth_estimateGas
endpointThere is a new notion of strict check which allows or not to take into account the balance of the sender (by default not strict)
strict mode == false
(default). We do not check the account balance for value transfert or to pay transaction fees.strict mode == true
. We check the account balance for value transfert or to pay transaction fees.Note :
If strict mode is disabled we put the maximum value of a long in the balance of the sender's account to allow all transactions to be doneIt is no longer possible to use the gasPrice if we are using 1559 transaction (
gasPrice
cannot be used withbaseFee
orfeeCap
)The gasPrice is respected if it is put in the request (by default 0 if not present)
JsonCallParameter
andCallParameter
have been split because there is a difference between the two objects (thestrict
field)Test performed
Changelog