Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of how JsonRpcMethods are created #159

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Redesign of how JsonRpcMethods are created #159

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9a4bd2
Refactor jsonrpc factories (#1)
CjHare Nov 5, 2019
e334aea
final modifier
Nov 5, 2019
89e4f67
more finals
Nov 5, 2019
df52f14
Consensus APIs
Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
final modifier 
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
  • Loading branch information
Christopher Hare committed Nov 5, 2019
commit e334aeadda9922724d7da9f46fc920c7664b50a7
2 changes: 1 addition & 1 deletion ...c/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/methods/ApiGroupJsonRpcMethods.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
public abstract class ApiGroupJsonRpcMethods implements JsonRpcMethods {

@Override
public Map<String, JsonRpcMethod> create(Collection<RpcApi> apis) {
public Map<String, JsonRpcMethod> create(final Collection<RpcApi> apis) {
return apis.contains(getApiGroup()) ? create() : Collections.emptyMap();
}

Expand Down