Added zero gasPrice validation for Quorum compatibility mode. #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarla
approved these changes
Nov 12, 2020
...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java
Outdated
Show resolved
Hide resolved
|
as discussed would be good to get the msg about zero gasPrice propagated to RPC response (currently "invalid params") |
Do we have a policy against putting TODO's into the codebase? I'm neutral but if so, we could flag to Nicolas Maurice to ensure we capture this in that work. Let me know if you want to go down that route instead of the TODO. |
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
macfarla
approved these changes
Nov 16, 2020
| @@ -30,7 +30,8 @@ public static ProtocolSchedule create( | |||
| config, | |||
| builder -> builder.difficultyCalculator(FixedDifficultyCalculators.calculator(config)), | |||
| privacyParameters, | |||
| isMetadataEnabled) | |||
| isMetadataEnabled, | |||
| config.isQuorum()) | |||
There was a problem hiding this comment.
should this be isGoQuorum()
...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidatorTest.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidatorTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Terry mark.terry@consensys.net
PR description
Updates transaction validation to enforce zero gasPrice when
isQuorumgenesis config is set.Fixed Issue(s)
Fixes #1551
Changelog