Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude quorum permissioning custom fork in genesis #1531

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Exclude quorum permissioning custom fork in genesis #1531

merged 2 commits into from
Nov 4, 2020

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Nov 4, 2020 •
edited
Loading

GoQuorum has added qip74Block to genesis - exclude this from forkId generation

Changelog

@macfarla macfarla added the TeamRevenant GH issues worked on by Revenant Team label Nov 4, 2020
lucassaldanha
lucassaldanha approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla mentioned this pull request Nov 4, 2020
Closed
@macfarla macfarla merged commit 40d5bfe into hyperledger:master Nov 4, 2020
@macfarla macfarla deleted the forkid branch November 4, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @lucassaldanha