Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-2798] Enable pruning by default for fast sync #135

Merged
merged 10 commits into from
Nov 4, 2019
Merged

[PAN-2798] Enable pruning by default for fast sync #135

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dcf291d
test new pruning default
RatanRSur Sep 23, 2019
063d0e1
enable pruning for fast sync
RatanRSur Oct 24, 2019
977a7da
wrap null in Optional.ofNullable
RatanRSur Oct 24, 2019
a04117f
fix missed rename
RatanRSur Oct 24, 2019
69d643d
Merge branch 'master' into pruning-enable
RatanRSur Oct 30, 2019
afd2f41
Merge branch 'master' into pruning-enable
RatanRSur Oct 31, 2019
cde3e5e
Merge branch 'master' into pruning-enable
RatanRSur Nov 4, 2019
e2cd7da
rename
RatanRSur Nov 4, 2019
b6bc1a3
rename
RatanRSur Nov 4, 2019
d7518c2
add explicit tests for enable and disabling pruning
RatanRSur Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add explicit tests for enable and disabling pruning 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
  • Loading branch information
@RatanRSur
RatanRSur committed Nov 4, 2019
commit d7518c201e691dfae32526d9779b7b4ee198abd9
13 changes: 12 additions & 1 deletion besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2349,7 +2349,7 @@ public void pruningIsDisabledIfSyncModeIsFull() {
}

@Test
public void pruningIsEnabledWhenSpecified() throws Exception {
public void pruningEnabledExplicitly() {
parseCommand("--pruning-enabled");

verify(mockControllerBuilder).isPruningEnabled(true);
Expand All @@ -2359,6 +2359,17 @@ public void pruningIsEnabledWhenSpecified() throws Exception {
assertThat(commandErrorOutput.toString()).isEmpty();
}

@Test
public void pruningDisabledExplicitly() {
parseCommand("--pruning-enabled=false");

verify(mockControllerBuilder).isPruningEnabled(false);
verify(mockControllerBuilder).build();

assertThat(commandOutput.toString()).isEmpty();
assertThat(commandErrorOutput.toString()).isEmpty();
}

@Test
public void pruningOptionsRequiresServiceToBeEnabled() {

Expand Down