Private Log Filters track enclavePublicKey and are removed when user removed from group #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
…ti-tenancy-onchain-remove-filter
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
lucassaldanha
previously requested changes
Aug 12, 2020
...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivNewFilter.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/privacy/DefaultPrivacyController.java
Outdated
Show resolved
Hide resolved
.../core/src/main/java/org/hyperledger/besu/ethereum/privacy/MultiTenancyPrivacyController.java
Outdated
Show resolved
Hide resolved
…ti-tenancy-onchain-remove-filter
…ti-tenancy-onchain-remove-filter
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
…ti-tenancy-onchain-remove-filter
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
…ti-tenancy-onchain-remove-filter
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
...hyperledger/besu/ethereum/mainnet/precompiles/privacy/OnChainPrivacyPrecompiledContract.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
pinges
requested changes
Aug 20, 2020
...i/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/filter/FilterManager.java
Show resolved
Hide resolved
...hyperledger/besu/ethereum/mainnet/precompiles/privacy/OnChainPrivacyPrecompiledContract.java
Outdated
Show resolved
Hide resolved
…ti-tenancy-onchain-remove-filter
…cy AND onchain groups enabled Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
mark-terry
reviewed
Aug 21, 2020
|
|
||
| final PrivateTransactionEvent removalEvent = | ||
| new PrivateTransactionEvent( | ||
| privateTransaction.getPrivacyGroupId().get().toBase64String(), removedParticipant); |
There was a problem hiding this comment.
Is there a chance for an NPE here?
There was a problem hiding this comment.
from within the onchain precompile?
There was a problem hiding this comment.
looking at the code, the calling method returns earlier if privacy group id is empty. I can refactor to make that clearer?
There was a problem hiding this comment.
Unchecked privateTransaction.getPrivacyGroupId().get() ?
There was a problem hiding this comment.
You're right - I missed that in the diff.
Any chance this function could be called from a different path?
mark-terry
reviewed
Aug 21, 2020
macfarla
dismissed
lucassaldanha’s stale review
Changes have been made, and @pinges has approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When multi-tenancy and removing user from onchain privacy group, send an event which is processed by the FilterManager, which triggers removal of any private log filters created by that user in that privacy group.
Fixed Issue(s)
See #883
Changelog
No changelog required since this is part of a larger feature