Fix sync timeout issue #1149
Merged
Fix sync timeout issue #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
AbdelStark
approved these changes
Jun 29, 2020
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
Jun 30, 2020
This PR fixes an error when downloading chain (Async operation failed) When there are several blocks which are very large (> 12M) and which are requested in the same segment (by default 200) we can have timeouts and never manage to synchronize. This modification will make it possible to gradually reduce the size of the segment with each attempt. Then the segment resumes its default size for the next blocks If the reduction is not enough at the last attempt we try with a single block Signed-off-by: Karim TAAM <karim.t2am@gmail.com> (cherry picked from commit 1755648) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
shemnon
pushed a commit
that referenced
this pull request
Jun 30, 2020
This PR fixes an error when downloading chain (Async operation failed) When there are several blocks which are very large (> 12M) and which are requested in the same segment (by default 200) we can have timeouts and never manage to synchronize. This modification will make it possible to gradually reduce the size of the segment with each attempt. Then the segment resumes its default size for the next blocks If the reduction is not enough at the last attempt we try with a single block Signed-off-by: Karim TAAM <karim.t2am@gmail.com> (cherry picked from commit 1755648) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
matkt
added a commit
that referenced
this pull request
Jul 24, 2020
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
Jul 28, 2020
Add hyperledger#1156 and hyperledger#1149 Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Ratan (Rai) Sur <ratan.r.sur@gmail.com> (cherry picked from commit baa11a2) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
shemnon
pushed a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
This PR fixes an error when downloading chain (Async operation failed)
When there are several blocks which are very large (> 12MB) and which are requested in the same segment (by default 200) we can have timeouts and never manage to synchronize. This modification will make it possible to gradually reduce the size of the segment with each attempt. Then the segment resumes its default size for the next blocks
If the reduction is not enough at the last attempt we try with a single block
Tested
LACCHAIN (Before) -> Always stuck after 20 minutes
LACCHAIN (After) -> Download restart after 2-5 minutes of sync