whitelist -> allowlist and on-chain -> onchain #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
mark-terry
reviewed
Jun 23, 2020
...ethereum/api/jsonrpc/internal/methods/permissioning/PermRemoveAccountsFromAllowlistTest.java
Outdated
Show resolved
Hide resolved
...su/ethereum/api/jsonrpc/internal/methods/permissioning/PermRemoveNodesFromAllowlistTest.java
Show resolved
Hide resolved
...r/besu/ethereum/api/jsonrpc/internal/methods/permissioning/PermGetAccountsAllowlistTest.java
Outdated
Show resolved
Hide resolved
...r/besu/ethereum/api/jsonrpc/internal/methods/permissioning/PermGetAccountsAllowlistTest.java
Outdated
Show resolved
Hide resolved
...besu/ethereum/api/jsonrpc/internal/methods/permissioning/PermAddAccountsToAllowlistTest.java
Show resolved
Hide resolved
| @@ -68,11 +68,11 @@ public JsonRpcResponse response(final JsonRpcRequestContext requestContext) { | |||
| } catch (final MultiTenancyValidationException e) { | |||
| LOG.error("Unauthorized privacy multi-tenancy rpc request. {}", e.getMessage()); | |||
| return new JsonRpcErrorResponse( | |||
| requestContext.getRequest().getId(), FIND_ON_CHAIN_PRIVACY_GROUP_ERROR); | |||
| requestContext.getRequest().getId(), FIND_ONCHAIN_PRIVACY_GROUP_ERROR); | |||
| } catch (final Exception e) { | |||
| LOG.error("Failed to fetch on chain privacy group", e); | |||
There was a problem hiding this comment.
Does this message need to be updated?
| NODE_WHITELIST_EXISTING_ENTRY(-32000, "Cannot add an existing node to allowlist"), | ||
| NODE_WHITELIST_MISSING_ENTRY(-32000, "Cannot remove an absent node from allowlist"), | ||
| NODE_WHITELIST_FIXED_NODE_CANNOT_BE_REMOVED( | ||
| NODE_ALLOWLIST_NOT_ENABLED(-32000, "Node allowlisting has not been enabled"), |
There was a problem hiding this comment.
"allowlisting" or "allowlist" ?
There was a problem hiding this comment.
I do not have a strong opinion on this
There was a problem hiding this comment.
ok we're deciding that allowlist is a noun not a verb. but changes will come in a new PR
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
rain-on
pushed a commit
to rain-on/besu
that referenced
this pull request
Jun 25, 2020
* whitelist -> allowlist and on-chain -> onchain Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net
More internal renames of whitelist -> allowlist
Also changed instances of on-chain -> onchain
See #1108