Add gauge to time mark duration #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
reviewed
Jun 2, 2020
| metricsSystem.createLongGauge( | ||
| BesuMetricCategory.PRUNER, | ||
| "mark_time_duration", | ||
| "Total number of seconds spent marking the state trie", |
There was a problem hiding this comment.
Cumulative or per marking run? Worth adding some verbiage to the help text to make it clear.
| @@ -94,6 +97,13 @@ public MarkSweepPruner( | |||
| BesuMetricCategory.PRUNER, | |||
| "sweep_operations_total", | |||
| "Total number of sweep operations performed"); | |||
|
|
|||
| markStopwatch = Stopwatch.createUnstarted(); | |||
| metricsSystem.createLongGauge( | |||
There was a problem hiding this comment.
Is MarkSweepPruner a singleton for the life of the java process? Counters can handle multiple counters, gauges will throw an exception when the second gauge is created.
There was a problem hiding this comment.
Yup, it's a singleton
shemnon
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to do performance monitoring/improvement of mark duration