-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger a timeout response after waiting x seconds on RPC calls #5589
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
P3
Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion)
RPC
Comments
jframe
added
TeamChupa
GH issues worked on by Chupacabara Team
TeamGroot
GH issues worked on by Groot Team
TeamRevenant
GH issues worked on by Revenant Team
labels
Jun 15, 2023
@ahamlat Please assign it to me. |
macfarla
added
P3
Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion)
help wanted
Extra attention is needed
and removed
TeamGroot
GH issues worked on by Groot Team
TeamRevenant
GH issues worked on by Revenant Team
TeamChupa
GH issues worked on by Chupacabara Team
labels
Jul 22, 2024
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 22, 2024
…status - Add verification for 408 (Request Timeout) status code on timeout - Add verification for timer cancellation in timeout scenario - Update successful execution test to verify timer cancellation - Mock timerId retrieval from context This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly tested in both timeout and successful execution scenarios, improving the test coverage and error handling for the JsonRpcExecutorHandler. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 22, 2024
… 408 status - Implement 408 (Request Timeout) status code on timeout in JsonRpcExecutorHandler - Update JsonRpcExecutorHandlerTest to verify 408 status and timer cancellation - Improve error handling and test coverage for timeout scenarios - Apply spotless formatting changes This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly implemented and tested, improving error handling for the JsonRpcExecutorHandler. Spotless formatting has been applied to maintain code style consistency. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 22, 2024
Removed temporary test code that was accidentally left in EthGetLogs.java. This code was not intended for the final implementation. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 22, 2024
…status - Add verification for 408 (Request Timeout) status code on timeout - Add verification for timer cancellation in timeout scenario - Update successful execution test to verify timer cancellation - Mock timerId retrieval from context This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly tested in both timeout and successful execution scenarios, improving the test coverage and error handling for the JsonRpcExecutorHandler. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 22, 2024
… 408 status - Implement 408 (Request Timeout) status code on timeout in JsonRpcExecutorHandler - Update JsonRpcExecutorHandlerTest to verify 408 status and timer cancellation - Improve error handling and test coverage for timeout scenarios - Apply spotless formatting changes This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly implemented and tested, improving error handling for the JsonRpcExecutorHandler. Spotless formatting has been applied to maintain code style consistency. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 22, 2024
Removed .run directory from Git tracking. This directory contains local IDE configuration files that should not be part of the repository. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 23, 2024
Removed temporary test code that was accidentally left in EthGetLogs.java. This code was not intended for the final implementation. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 23, 2024
…status - Add verification for 408 (Request Timeout) status code on timeout - Add verification for timer cancellation in timeout scenario - Update successful execution test to verify timer cancellation - Mock timerId retrieval from context This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly tested in both timeout and successful execution scenarios, improving the test coverage and error handling for the JsonRpcExecutorHandler. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 23, 2024
… 408 status - Implement 408 (Request Timeout) status code on timeout in JsonRpcExecutorHandler - Update JsonRpcExecutorHandlerTest to verify 408 status and timer cancellation - Improve error handling and test coverage for timeout scenarios - Apply spotless formatting changes This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly implemented and tested, improving error handling for the JsonRpcExecutorHandler. Spotless formatting has been applied to maintain code style consistency. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 23, 2024
…status - Add verification for 408 (Request Timeout) status code on timeout - Add verification for timer cancellation in timeout scenario - Update successful execution test to verify timer cancellation - Mock timerId retrieval from context This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly tested in both timeout and successful execution scenarios, improving the test coverage and error handling for the JsonRpcExecutorHandler. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 23, 2024
… 408 status - Implement 408 (Request Timeout) status code on timeout in JsonRpcExecutorHandler - Update JsonRpcExecutorHandlerTest to verify 408 status and timer cancellation - Improve error handling and test coverage for timeout scenarios - Apply spotless formatting changes This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly implemented and tested, improving error handling for the JsonRpcExecutorHandler. Spotless formatting has been applied to maintain code style consistency. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 23, 2024
Removed .run directory from Git tracking. This directory contains local IDE configuration files that should not be part of the repository. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
Removed temporary test code that was accidentally left in EthGetLogs.java. This code was not intended for the final implementation. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
…status - Add verification for 408 (Request Timeout) status code on timeout - Add verification for timer cancellation in timeout scenario - Update successful execution test to verify timer cancellation - Mock timerId retrieval from context This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly tested in both timeout and successful execution scenarios, improving the test coverage and error handling for the JsonRpcExecutorHandler. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
… 408 status - Implement 408 (Request Timeout) status code on timeout in JsonRpcExecutorHandler - Update JsonRpcExecutorHandlerTest to verify 408 status and timer cancellation - Improve error handling and test coverage for timeout scenarios - Apply spotless formatting changes This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly implemented and tested, improving error handling for the JsonRpcExecutorHandler. Spotless formatting has been applied to maintain code style consistency. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
…status - Add verification for 408 (Request Timeout) status code on timeout - Add verification for timer cancellation in timeout scenario - Update successful execution test to verify timer cancellation - Mock timerId retrieval from context This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly tested in both timeout and successful execution scenarios, improving the test coverage and error handling for the JsonRpcExecutorHandler. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
… 408 status - Implement 408 (Request Timeout) status code on timeout in JsonRpcExecutorHandler - Update JsonRpcExecutorHandlerTest to verify 408 status and timer cancellation - Improve error handling and test coverage for timeout scenarios - Apply spotless formatting changes This change ensures that a 408 status code is returned on timeout and that timer cancellation is properly implemented and tested, improving error handling for the JsonRpcExecutorHandler. Spotless formatting has been applied to maintain code style consistency. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
Removed .run directory from Git tracking. This directory contains local IDE configuration files that should not be part of the repository. Issue: hyperledger#5589 PR: hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
cloudspores
added a commit
to cloudspores/besu
that referenced
this issue
Aug 26, 2024
…a-timeout # rebase onto main. Issue hyperledger#5589 PR hyperledger#7469 Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
P3
Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion)
RPC
Description
Besu does not trigger a timeout response after some time ex. 30 seconds. When running Eth_getLogs from earliest to latest, Geth responds "request timed out" after 30 seconds. Besu keeps running and hanging the thread. I see some RpcMethodTimeoutException errors got triggered in the logs but it didn't change the output, the client (the caller) was still waiting for a response.
Acceptance Criteria
Steps to Reproduce (Bug)
Have a Besu synced node on mainnet and launch this RPC call
Compare the result with Geth.
Expected behavior: [What you expect to happen]
Trigger a timeout response after waiting x seconds on an RPC call
Actual behavior: [What actually happens]
The caller is waiting indefinitely on very slow calls
Frequency: [What percentage of the time does it occur?
100% on some very slow calls.
Versions (Add all that apply)
The text was updated successfully, but these errors were encountered: