add missing cost methods to interface, add method to get RLP of trans…

…action

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java

@@ -15,6 +15,7 @@
 package org.hyperledger.besu.datatypes;
 
 import org.hyperledger.besu.crypto.SECPSignature;
+import org.hyperledger.besu.ethereum.rlp.RLPOutput;
 
 import java.math.BigInteger;
 import java.util.List;
@@ -265,4 +266,45 @@ default Optional<? extends Quantity> getMaxFeePerDataGas() {
    * @return optional access list
    */
   Optional<List<AccessListEntry>> getAccessList();
+
+  /**
+   * Writes the transaction to RLP
+   *
+   * @param out the output to write the transaction to
+   */
+  void writeTo(final RLPOutput out);
+
+  /**
+   * Calculates the up-front cost for the gas and data gas the transaction can use.
+   *
+   * @param gasPrice the gas price to use
+   * @param dataGasPrice the data gas price to use
+   * @return the up-front cost for the gas the transaction can use.
+   */
+  Wei getUpfrontGasCost(final Wei gasPrice, final Wei dataGasPrice, final long totalDataGas);
+
+  /**
+   * Calculates the up-front cost for the transaction.
+   *
+   * <p>The up-front cost is paid by the sender account before the transaction is executed. The
+   * sender must have the amount in its account balance to execute and some of this amount may be
+   * refunded after the transaction has executed.
+   *
+   * @return the up-front gas cost for the transaction
+   */
+  Wei getUpfrontCost(final long totalDataGas);
+
+  /**
+   * Calculates the effectiveGasPrice of a transaction on the basis of an {@code Optional<Long>}
+   * baseFee and handles unwrapping Optional fee parameters. If baseFee is present, effective gas is
+   * calculated as:
+   *
+   * <p>min((baseFeePerGas + maxPriorityFeePerGas), maxFeePerGas)
+   *
+   * <p>Otherwise, return gasPrice for legacy transactions.
+   *
+   * @param baseFeePerGas optional baseFee from the block header, if we are post-london
+   * @return the effective gas price.
+   */
+  Wei getEffectiveGasPrice(final Optional<Wei> baseFeePerGas);
 }

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

@@ -627,6 +627,7 @@ private Bytes32 getOrComputeSenderRecoveryHash() {
    *
    * @param out the output to write the transaction to
    */
+  @Override
   public void writeTo(final RLPOutput out) {
     TransactionEncoder.encodeForWire(this, out);
   }
@@ -734,6 +735,7 @@ private boolean isUpfrontGasCostTooHigh() {
    * @param dataGasPrice the data gas price to use
    * @return the up-front cost for the gas the transaction can use.
    */
+  @Override
   public Wei getUpfrontGasCost(
       final Wei gasPrice, final Wei dataGasPrice, final long totalDataGas) {
     if (gasPrice == null || gasPrice.isZero()) {
@@ -770,6 +772,7 @@ private BigInteger calculateUpfrontGasCost(
    *
    * @return the up-front gas cost for the transaction
    */
+  @Override
   public Wei getUpfrontCost(final long totalDataGas) {
     return getMaxUpfrontGasCost(totalDataGas).addExact(getValue());
   }
@@ -788,6 +791,7 @@ public Wei getMaxGasPrice() {
                     new IllegalStateException(
                         "Transaction requires either gasPrice or maxFeePerGas")));
   }
+
   /**
    * Calculates the effectiveGasPrice of a transaction on the basis of an {@code Optional<Long>}
    * baseFee and handles unwrapping Optional fee parameters. If baseFee is present, effective gas is
@@ -800,6 +804,7 @@ public Wei getMaxGasPrice() {
    * @param baseFeePerGas optional baseFee from the block header, if we are post-london
    * @return the effective gas price.
    */
+  @Override
   public final Wei getEffectiveGasPrice(final Optional<Wei> baseFeePerGas) {
     return getEffectivePriorityFeePerGas(baseFeePerGas).addExact(baseFeePerGas.orElse(Wei.ZERO));
   }