-
Notifications
You must be signed in to change notification settings - Fork 880
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PIE-1846] Add an experimental flag for disabling timers (#1837)
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
- Loading branch information
Showing
7 changed files
with
152 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
pantheon/src/main/java/tech/pegasys/pantheon/cli/options/MetricsCLIOptions.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright 2019 ConsenSys AG. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package tech.pegasys.pantheon.cli.options; | ||
|
|
||
| import tech.pegasys.pantheon.metrics.prometheus.MetricsConfiguration; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import picocli.CommandLine; | ||
|
|
||
| public class MetricsCLIOptions implements CLIOptions<MetricsConfiguration.Builder> { | ||
| private static final String TIMERS_ENABLED_FLAG = "--Xmetrics-timers-enabled"; | ||
|
|
||
| @CommandLine.Option( | ||
| names = TIMERS_ENABLED_FLAG, | ||
| hidden = true, | ||
| defaultValue = "true", | ||
| description = "Whether to enable timer metrics (default: ${DEFAULT-VALUE}).") | ||
| private Boolean timersEnabled = MetricsConfiguration.DEFAULT_TIMERS_ENABLED; | ||
|
|
||
| private MetricsCLIOptions() {} | ||
|
|
||
| public static MetricsCLIOptions create() { | ||
| return new MetricsCLIOptions(); | ||
| } | ||
|
|
||
| public static MetricsCLIOptions fromConfiguration(final MetricsConfiguration config) { | ||
| final MetricsCLIOptions metricsOptions = create(); | ||
| metricsOptions.timersEnabled = config.isTimersEnabled(); | ||
| return metricsOptions; | ||
| } | ||
|
|
||
| @Override | ||
| public MetricsConfiguration.Builder toDomainObject() { | ||
| return MetricsConfiguration.builder().timersEnabled(timersEnabled); | ||
| } | ||
|
|
||
| @Override | ||
| public List<String> getCLIOptions() { | ||
| return Arrays.asList(TIMERS_ENABLED_FLAG + "=" + timersEnabled.toString()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
pantheon/src/test/java/tech/pegasys/pantheon/cli/options/MetricsCLIOptionsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Copyright 2019 ConsenSys AG. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package tech.pegasys.pantheon.cli.options; | ||
|
|
||
| import tech.pegasys.pantheon.metrics.prometheus.MetricsConfiguration; | ||
|
|
||
| public class MetricsCLIOptionsTest | ||
| extends AbstractCLIOptionsTest<MetricsConfiguration.Builder, MetricsCLIOptions> { | ||
|
|
||
| @Override | ||
| MetricsConfiguration.Builder createDefaultDomainObject() { | ||
| return MetricsConfiguration.builder(); | ||
| } | ||
|
|
||
| @Override | ||
| MetricsConfiguration.Builder createCustomizedDomainObject() { | ||
| return MetricsConfiguration.builder() | ||
| .timersEnabled(!MetricsConfiguration.DEFAULT_TIMERS_ENABLED); | ||
| } | ||
|
|
||
| @Override | ||
| MetricsCLIOptions optionsFromDomainObject(final MetricsConfiguration.Builder domainObject) { | ||
| return MetricsCLIOptions.fromConfiguration(domainObject.build()); | ||
| } | ||
|
|
||
| @Override | ||
| MetricsCLIOptions getOptionsFromPantheonCommand(final TestPantheonCommand pantheonCommand) { | ||
| return pantheonCommand.getMetricsCLIOptions(); | ||
| } | ||
| } |