Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switched to pnpm and added react native example app #249

Merged

Conversation

berendsliedrecht
Copy link
Contributor

PR got a bit bigger than expected.

  • Move from yarn to pnpm as it makes dealing with workspaces a lot easier
  • Added a React native example app. Right now it does not include an easy way to use locally-built binaries. This should be added in the future, but it can get quite complex.
  • Improved the registration of the React Native module a bit, might be worthwhile in the future to see if we can move this to an expo module as it would decrease maintenance a lot.

Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like trailing commas, but I'm fine with these changes 👍

@@ -1,7 +1,7 @@
{
"version": "0.2.0-dev.1",
"useWorkspaces": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think useWorkspaces was deprecated in lerna 7 right?

const result = anoncredsModule.install()
if (!result)
throw new Error(
'Failed to create a new MMKV instance: The native MMKV Module could not be installed! Looks like something went wrong when installing JSI bindings.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Failed to create a new MMKV instance: The native MMKV Module could not be installed! Looks like something went wrong when installing JSI bindings.'
'Failed to create a new Anoncreds instance: The native Anoncreds Module could not be installed! Looks like something went wrong when installing JSI bindings.'

@berendsliedrecht berendsliedrecht force-pushed the js-module-installation branch 2 times, most recently from d47f9f3 to db966ff Compare September 25, 2023 08:23
Signed-off-by: Berend Sliedrecht <blu3beri@proton.me>
@berendsliedrecht berendsliedrecht merged commit a92b4c7 into hyperledger:main Sep 25, 2023
25 checks passed
@berendsliedrecht berendsliedrecht deleted the js-module-installation branch September 25, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants