Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the Log addition to contract events #375

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Fixes the Log addition to contract events #375

merged 2 commits into from
Feb 27, 2018

Conversation

danieldietrich
Copy link
Contributor

@danieldietrich danieldietrich commented Feb 22, 2018

Fixes #270

See PR #275, especially this review comment.

Note: The issue #364 hinders me to squash the commits.

@codecov
Copy link

codecov bot commented Feb 22, 2018

Codecov Report

Merging #375 into master will increase coverage by 0.03%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
+ Coverage     76.55%   76.59%   +0.03%     
- Complexity     1612     1616       +4     
============================================
  Files           215      215              
  Lines          5985     5994       +9     
  Branches        947      946       -1     
============================================
+ Hits           4582     4591       +9     
- Misses         1176     1177       +1     
+ Partials        227      226       -1
Impacted Files Coverage Δ Complexity Δ
...ava/org/web3j/codegen/SolidityFunctionWrapper.java 97.42% <100%> (ø) 101 <0> (ø) ⬇️
core/src/main/java/org/web3j/tx/Contract.java 77.77% <88.23%> (+2.56%) 44 <6> (+5) ⬆️
...ore/src/main/java/org/web3j/utils/Observables.java 80% <0%> (-4%) 9% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf8348...2928944. Read the comment docs.

@iikirilov iikirilov merged commit b54a29e into hyperledger-web3j:master Feb 27, 2018
@iikirilov
Copy link
Contributor

Thanks!

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018
…g-ref

Fixes the Log addition to contract events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants