Counter on duplicated event names #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioIOB
requested review from
conor10,
gtebrean and
NickSneo
as code owners
Signed-off-by: Sergio Mendoza <sergio@io.builders>
SergioIOB
force-pushed
the
feature/fixDuplicatedEventNames
branch
from
1ad3cba to
95e9034
Compare
gtebrean
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for when more than 1 event with the same name but different signature is found in a contract
This PR is a continuation of #1872 testing and fixing that the event corresponds to the function in buildEventFunctions
Where should the reviewer start?
It is a simple PR, it only has a modified file and the corresponding test
Why is it needed?
Same reasons as #1872
Relative to issue #1781