Enrich generateBothCallAndSend feature in TruffleJsonFunctionWrapperGenerator #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
============================================
- Coverage 69.23% 69.22% -0.02%
+ Complexity 3125 3120 -5
============================================
Files 493 493
Lines 13156 13151 -5
Branches 1696 1694 -2
============================================
- Hits 9109 9104 -5
- Misses 3557 3566 +9
+ Partials 490 481 -9 ☔ View full report in Codecov by Sentry. |
|
@tonykwok1992 Please rebase to master and do spotlessApply |
tonykwok1992
force-pushed
the
truffle-generate-both
branch
from
d73db24 to
3fddbda
Compare
|
rebased |
tonykwok1992
force-pushed
the
truffle-generate-both
branch
from
3fddbda to
594bd93
Compare
|
rebased again |
NickSneo
requested changes
Mar 22, 2024
| @@ -40,6 +42,8 @@ | |||
|
|
|||
| import static org.web3j.codegen.Console.exitError; | |||
| import static org.web3j.utils.Collection.tail; | |||
| import static picocli.CommandLine.*; | |||
There was a problem hiding this comment.
Plz remove this wildcard import
gtebrean
reviewed
Mar 22, 2024
| private String destinationDirLocation; | ||
|
|
||
| @Option( | ||
| names = {"-B", "--generateBoth"}, |
There was a problem hiding this comment.
rename this to generateCallAndSend with "-cs"
There was a problem hiding this comment.
I think it will be better to be consistent with SolidityFunctionWrapperGenerator which use "-B", "--generateBoth" ?
tonykwok1992
force-pushed
the
truffle-generate-both
branch
from
594bd93 to
0dcfeee
Compare
|
rebased |
gtebrean
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
All files
Why is it needed?
To be able to use
web3j generate trufflewith flag--generateBoth/-Bto generator both send and call in wrapper generation using truffle option