Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polling processors to attempts work as expected #1716

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Fix polling processors to attempts work as expected #1716

merged 1 commit into from
Jun 20, 2022

Conversation

rymuff
Copy link

@rymuff rymuff commented May 31, 2022 •
edited
Loading

What does this PR do?

Fix polling processors to attempts work as expected

Where should the reviewer start?

Issue #1533

Why is it needed?

In PollingTransactionReceiptProcessor and PollingPrivateTransactionReceiptProcessor,
getTransactionReceipt() calls sendTransactionReceiptRequest() N + 1 times, when attempts is N

fix #1533

@rymuff rymuff requested a review from conor10 as a code owner May 31, 2022 07:14
@andrii-kl andrii-kl self-assigned this Jun 16, 2022
@andrii-kl andrii-kl merged commit d828a3e into hyperledger-web3j:master Jun 20, 2022
@rymuff rymuff deleted the fixPollingTransactionReceiptProcessor branch July 14, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-kl andrii-kl andrii-kl approved these changes

@conor10 conor10 Awaiting requested review from conor10

Assignees

@andrii-kl andrii-kl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PollingTransactionReceiptProcessor attempts does not work as expected
3 participants
@rymuff @andrii-kl @junsung-cho