Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location to solidity import directive #630

Merged
merged 5 commits into from
Jan 8, 2022

Conversation

rkrasiuk
Copy link
Contributor

@rkrasiuk rkrasiuk commented Jan 8, 2022

Pertaining to the discussion in ethers-rs/feat(solc): flatten PR, add location to the import directives to be able to parse them out.

cc: @mattsse

Signed-off-by: Roman Krasiuk <rokrassyuk@gmail.com>
Signed-off-by: Roman Krasiuk <rokrassyuk@gmail.com>
Signed-off-by: Roman Krasiuk <rokrassyuk@gmail.com>
Signed-off-by: Roman Krasiuk <rokrassyuk@gmail.com>
Signed-off-by: Roman Krasiuk <rokrassyuk@gmail.com>
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, as long as CI passes

@seanyoung seanyoung merged commit 190f720 into hyperledger-solang:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants