Skip to content

Ordered Ledger List #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NhoxxKienn merged 4 commits into from
Dec 2, 2025
Merged

Ordered Ledger List #436

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a0c6c3
fix(asset): keep order of assets for ledgerID array
sophia1ch May 21, 2025
b14a610
Merge branch 'main' into fix-cross-chain
sophia1ch Nov 25, 2025
c4561e5
Merge branch 'main' into fix-cross-chain
NhoxxKienn Dec 2, 2025
2f1c717
Merge branch 'main' into fix-cross-chain
NhoxxKienn Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions channel/multi/asset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ type (

// LedgerIDs returns the identifiers of the associated ledgers.
func (a assets) LedgerIDs() ([]LedgerBackendID, error) {
ids := make(map[LedgerBackendKey]LedgerBackendID)
var ids []LedgerBackendID
seen := make(map[LedgerBackendKey]struct{})

for _, asset := range a {
ma, ok := asset.(Asset)
Expand All @@ -57,18 +58,19 @@ func (a assets) LedgerIDs() ([]LedgerBackendID, error) {
}

assetID := ma.LedgerBackendID()
key := LedgerBackendKey{
BackendID: assetID.BackendID(),
LedgerID: string(assetID.LedgerID().MapKey()),
}
if _, exists := seen[key]; exists {
continue // skip duplicates, keep first occurrence order
}
seen[key] = struct{}{}

ids[LedgerBackendKey{BackendID: assetID.BackendID(), LedgerID: string(assetID.LedgerID().MapKey())}] = assetID
}
idsArray := make([]LedgerBackendID, len(ids))

i := 0
for _, v := range ids {
idsArray[i] = v
i++
ids = append(ids, assetID)
}

return idsArray, nil
return ids, nil
}

// IsMultiLedgerAssets returns whether the assets are from multiple ledgers.
Expand Down