Cache first channel update #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgeihs
force-pushed
the
cache-first-update
branch
from
3e9e792 to
1feb16a
Compare
ggwpez
suggested changes
Mar 1, 2021
matthiasgeihs
force-pushed
the
cache-first-update
branch
from
1feb16a to
817a0d5
Compare
ggwpez
approved these changes
Mar 1, 2021
Contributor
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
Looks good! Just needs a rebase
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
cache-first-update
branch
from
817a0d5 to
95631a3
Compare
NhoxxKienn
pushed a commit
that referenced
this pull request
Dec 2, 2025
Sync libp2p PR with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interacting on a channel directly after channel opening, it can happen that the other side has not yet completed the channel opening procedure. In this case, there was a notice about a channel update for an unknown channel and the update would never go through. This change fixes this bug by caching the first channel update until the channel opening is complete.