Enable context check linter #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
manoranjith
suggested changes
Dec 7, 2021
|
LGTM. Can you rebase onto the tip of base branch and squash the review commits ? |
matthiasgeihs
force-pushed
the
275-enable-context-check-linter
branch
from
88b88c8 to
be11e3c
Compare
Contributor
Author
|
Rebased and squashed. |
manoranjith
previously approved these changes
Dec 8, 2021
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
According to the package documentation, a context should not be stored in a struct type. Furthermore, the context had no major relevance. Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
275-enable-context-check-linter
branch
from
be11e3c to
029e577
Compare
Contributor
Author
|
rebased |
manoranjith
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275