Skip to content

Conversation

@matthiasgeihs
Copy link
Contributor

Closes #147

@matthiasgeihs matthiasgeihs requested a review from ggwpez July 22, 2021 13:29
Copy link
Contributor

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one change request, others are comments.

@matthiasgeihs
Copy link
Contributor Author

@ggwpez Addressed your comments, please have another look.

@matthiasgeihs matthiasgeihs requested a review from ggwpez July 22, 2021 18:12
Copy link
Contributor

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume you still squash.

Signed-off-by: Matthias Geihs <matthias@perun.network>
@matthiasgeihs matthiasgeihs force-pushed the 147-withdraw-progressed-final branch from c987610 to ff2a698 Compare July 23, 2021 08:07
@matthiasgeihs
Copy link
Contributor Author

Rebased, please check and merge.

@matthiasgeihs matthiasgeihs requested a review from ggwpez July 23, 2021 08:10
@ggwpez ggwpez merged commit 911cf0b into hyperledger-labs:dev Jul 23, 2021
@ggwpez ggwpez deleted the 147-withdraw-progressed-final branch July 23, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ensureConcluded fails when channel has been progressed to final

2 participants