This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Isolate dependency on scorex.crypto to a single file #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceilican
commented
Jun 17, 2018
| @@ -0,0 +1,64 @@ | |||
| package scorex.core | |||
|
|
|||
| // The purpose of this package is to act as a single interface | |||
There was a problem hiding this comment.
This is the most important file in this PR.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, many files in scorex.core depended on scorex.crypto. This PR creates a file that serves as interface to scorex.crypto. All other files now only depend on this new file. And this new file is the only file that depends on scorex.crypto.
This PR will ease the replacement of
Array[Byte]byByteStringin #221.