Generated protobuf files with protobuf 3.12.4 on Ubuntu 21.04 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: G.Bazior <bazior@agh.edu.pl>
baziorek
added
bug
dependencies
iceseer
approved these changes
Jul 27, 2022
This was referenced Aug 5, 2022
baziorek
added a commit
to baziorek/iroha-python
that referenced
this pull request
Aug 8, 2022
…edger-iroha#104) Signed-off-by: G.Bazior <bazior@agh.edu.pl>
baziorek
added a commit
that referenced
this pull request
Aug 22, 2022
* Extending TxPaginationMeta in queries (#77) * quries extended * example added * docs comment added * schema changed * formatting fixed * ordering added * edge case fix, now 0 passed as height or timestamp is passing * PaginationMeta in GetPendingTransactions * examples/query_transactions.py Signed-off-by: Piotr Pawlowski <ppiotru@gmail.com> Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Update proto files and generated python files to support Iroha 1.4 (#96) * Update proto files with script `download-schema.py` Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl> * Generated python files from protobuf files with script `compile-proto.py` Signed-off-by: G.Bazior <bazior@agh.edu.pl> Co-authored-by: Grzegorz Bazior <g.bazior@yodiss.pl> Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Corrected merge - rerun scripts: download-schema.py and compile-proto.py Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Tab -> spaces Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Add ability to provide custom TLS cert (#63) Signed-off-by: Stepan Lavrentev <lawrentievsv@gmail.com> Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Add ordering sequence to params in query (#73) * Add ordering sequence to params Makes possible to add ordering sequence to Query. Fixes #72 Signed-off-by: Rafik Naccache <rafik@fekr.tech> * Add :param ordering_sequence: Signed-off-by: Rafik Naccache <rafik@fekr.tech> * Fix wrong example for :param ordering_sequence: Signed-off-by: Rafik Naccache <rafik@fekr.tech> * fix wrong ordering message construction in query After more documentation I got to the way to construct to ordering object Signed-off-by: Rafik Naccache <rafik@fekr.tech> * remove redundant OR clause to manage ordering_sequence Signed-off-by: Rafik Naccache <rafik@fekr.tech> Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Extending TxPaginationMeta in queries (#77) * quries extended * example added * docs comment added * schema changed * formatting fixed * ordering added * edge case fix, now 0 passed as height or timestamp is passing * PaginationMeta in GetPendingTransactions * examples/query_transactions.py Signed-off-by: Piotr Pawlowski <ppiotru@gmail.com> Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Added missing changes from Pawlak00@b6d7f42 corrected in #77 Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Examples refactor + added example of MST developed by Leo (#103) * Refactoring of example tx-example.py Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Added sample of MST transactions. The code was originally developed by Leo: https://github.com/iptelephony/jubilant-engine but he agreed to add his code to examples Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Generated protobuf files with protobuf 3.12.4 on Ubuntu 21.04 (#104) Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Serious refactoring + improvements + adding new examples for Iroha 1 (#107) * Update README * Refactoring in tls-example.py * A little refactoring of batch-example.py * Small refactoring of blocks-query.py * Small refactoring of infinite-blocks-stream.py * Added sample how to use ordering of result transactions * Refacroting in query_transactions.py * Renamed file with convention used in other files * Added examples in comments * Some refactoring in examples + added docstring in each file * chmod +x * Updated iroha version from 1.4 -> 1.5 Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Add autorestart to iroha Signed-off-by: Alexey Rodionov <rodionov12@gmail.com> * Cherry-pick fix Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Generated python files from protobuf on Ubuntu:20.04 Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Dependencies fix Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Added space in logging after review Signed-off-by: G.Bazior <bazior@agh.edu.pl> * Made import in code more readable after review Signed-off-by: G.Bazior <bazior@agh.edu.pl> Signed-off-by: Piotr Pawlowski <ppiotru@gmail.com> Signed-off-by: G.Bazior <bazior@agh.edu.pl> Signed-off-by: Stepan Lavrentev <lawrentievsv@gmail.com> Signed-off-by: Rafik Naccache <rafik@fekr.tech> Signed-off-by: Alexey Rodionov <rodionov12@gmail.com> Co-authored-by: Piotr Pawłowski <68233055+Pawlak00@users.noreply.github.com> Co-authored-by: Grzegorz Bazior <g.bazior@yodiss.pl> Co-authored-by: Stepan Lavrentev <40560660+stepanLav@users.noreply.github.com> Co-authored-by: Rafik NACCACHE <rafik@fekr.tech> Co-authored-by: Alexey Rodionov <rodionov12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago I updated python files from protobufs (*.proto) files. It can be done easy with attached scripts:
Everything was working, I was happy and the iroha-python 1.4.1 was released. Then in our servers with Ubuntu 21.04 I tried to use iroha 1.4.1 instead of iroha 1.0.0, but unfortunately I noticed errors described here: #102
After some investigation I found why it is not working - I have Manjaro, which has almost always newest packages, so generated protobufs was generated with really new version (currently I have
protoc --version libprotoc 3.21.1). Everything was working in my OS - Manjaro. But debian-based servers usually have not everything as new as Manjaro, so those files was not compatible with versions in Ubuntu 21.04 (which hasprotoc 3.12.4).What is done in the PR is just generating python files from *.proto in Ubuntu 20.04 LTS:
Tests:
pip3 install iroha==1.0.0 && python3 -c 'import iroha'- works OK, but we want new versionpip3 install iroha==1.4.1 && PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python python3 -c 'import iroha'- works OK, but is may looks strange for new userspip3 install "git+https://github.com/baziorek/iroha-python.git@generate_protobufs_again" && python3 -c 'import iroha'- works OKSummary:
So IMO we should downgrade generated protobuf files to be in lower version (I've generated in Manjaro which has
protoc --version libprotoc 3.21.1), but rather users would have earlier versions (currently Ubuntu 21.04 has protobuflibprotoc 3.12.4). For users would be easier if they don't need extra flag to run simplest examplePROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python.