Skip to content

refactor(plugin-htlc-eth-besu): stop using the deprecated api.encodePacked #2531

Open
@petermetz

Description

Description

Stop using the abi.encodePacked() call in the packages/cactus-plugin-htlc-eth-besu/src/main/solidity/contracts/HashTimeLock.sol contract because that method has been deprecated according to [1]

[1] ethereum/solidity#11593

Acceptance Criteria

  1. Tests are still passing
  2. The new encoding call does not make this a breaking change, e.g. the outputs are consistent so that the test cases do not need to be changed to keep passing after the contract have been re-deployed.
  3. Make sure to update the compiled .json artifact of the .sol source code file so that the tests do end up using the new revision of the .sol code.

cc: @RafaelAPB

Metadata

Assignees

Labels

BesuHacktoberfestHacktoberfest participants are welcome to take a stab at issues marked with this label.P4Priority 4: LowSecurityRelated to existing or potential security vulnerabilitiesgood-first-issueGood for newcomersgood-first-issue-300-advanced

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions