Skip to content
This repository was archived by the owner on Jun 1, 2022. It is now read-only.
This repository was archived by the owner on Jun 1, 2022. It is now read-only.

OutgoingUrl, OkHttpClient and BearerTokenSupplier should be not be required for incoming-only IlpOverHttpLinks #409

Open
@nhartner

Description

@nhartner

IlpOverHttpLink constructor requires both outgoingUrl and bearerTokenSupplier parameters. This should only be required if the IlpOverHttpLink needs to send packets. It should not be required for an incoming-only IlpOverHttpLink.

Consider moving OutgoingUrl, OkHttpClient and BearerTokenSupplier into an OutgoingConnectionSupplier class which uses these fields to construct an http connection. IlpOverHttpLink constructor should have an optional OutgoingConnectionSupplier parameter. If IlpOverHttpLink#sendPacket is invoked, only then will OutgoingConnectionSupplier be required.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions