This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
add time duration logging to runtime go code #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkel
reviewed
Nov 1, 2017
| defer func() { logger.Debug("Exiting DataCollection.get", result) }() | ||
|
|
||
| // Validate the arguments from JavaScript. | ||
| id := vm.RequireString(0) | ||
| vm.RequireFunction(1) | ||
|
|
||
| increment := time.Now(); |
There was a problem hiding this comment.
I don't think you will care about the time it takes to create a composite key. This is actually a very simple method that just does string concatenation.
davidkel
reviewed
Nov 1, 2017
| @@ -203,6 +241,9 @@ func (dataCollection *DataCollection) exists(vm *duktape.Context) (result int) { | |||
| return 0 | |||
| } | |||
|
|
|||
| logger.Debug("@perf DataCollection.get CreateCompositeKey duration for [", dataCollection.CollectionID, "] and transaction [", dataCollection.Stub.GetTxID(),"] :", time.Now().Sub(increment)) | |||
There was a problem hiding this comment.
same comment about createCompositeKey
davidkel
reviewed
Nov 1, 2017
| @@ -252,6 +304,8 @@ func (dataCollection *DataCollection) add(vm *duktape.Context) (result int) { | |||
| return 0 | |||
| } | |||
|
|
|||
| logger.Debug("@perf DataCollection.get CreateCompositeKey duration for [", dataCollection.CollectionID, "] and transaction [", dataCollection.Stub.GetTxID(),"] :", time.Now().Sub(increment)) | |||
There was a problem hiding this comment.
same about createCompositeKey
davidkel
reviewed
Nov 1, 2017
| @@ -319,6 +387,9 @@ func (dataCollection *DataCollection) update(vm *duktape.Context) (result int) { | |||
| return 0 | |||
| } | |||
|
|
|||
| logger.Debug("@perf DataCollection.update CreateCompositeKey duration for collection [",dataCollection.CollectionID, "] and transaction [", dataCollection.Stub.GetTxID(),"] :", time.Now().Sub(increment)) | |||
There was a problem hiding this comment.
same comment about createCompositeKey
davidkel
reviewed
Nov 1, 2017
| @@ -378,6 +463,9 @@ func (dataCollection *DataCollection) remove(vm *duktape.Context) (result int) { | |||
| return 0 | |||
| } | |||
|
|
|||
| logger.Debug("@perf DataCollection.remove CreateCompositeKey duration for collection [",dataCollection.CollectionID, "] and transaction [", dataCollection.Stub.GetTxID(),"] :", time.Now().Sub(increment)) | |||
There was a problem hiding this comment.
same comment about createCompositeKey
davidkel
reviewed
Nov 1, 2017
| @@ -254,18 +279,26 @@ func (dataService *DataService) getCollection(vm *duktape.Context) (result int) | |||
| if vm.Pcall(2) == duktape.ExecError { | |||
| panic(vm.ToString(-1)) | |||
| } | |||
|
|
|||
| logger.Debug("@perf DataService.getCollection callback duraion for txnId [", dataService.Stub.GetTxID(), "] : ", time.Now().Sub(increment)) | |||
There was a problem hiding this comment.
minor spelling mistake :-)
davidkel
reviewed
Nov 1, 2017
| @@ -278,6 +311,9 @@ func (dataService *DataService) existsCollection(vm *duktape.Context) (result in | |||
| return 0 | |||
| } | |||
|
|
|||
| logger.Debug("@perf DataService.existsCollection CreateCompositeKey duration for txnId [", dataService.Stub.GetTxID(), "] : ", time.Now().Sub(increment)) | |||
There was a problem hiding this comment.
createCompositeKey comment
davidkel
reviewed
Nov 1, 2017
| defer func() { logger.Debug("Exiting DataService.clearCollection", err) }() | ||
|
|
||
| increment = time.Now(); |
nklincoln
force-pushed
the
add-perf-trace
branch
2 times, most recently
from
b1da804
to
a4fab97
Compare
Signed-off-by: Nick Lincoln <nkl199@yahoo.co.uk>
nklincoln
force-pushed
the
add-perf-trace
branch
from
a4fab97
to
413069b
Compare
davidkel
approved these changes
Nov 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2514
Adds duration timestamp information through the go code under runtime hlfv1, will be observed within debug trace only