This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Remove References to ID Card #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsmith
suggested changes
Nov 1, 2017
| <label class="radio-label" for="participantCard"><h3>Participant Card</h3></label> | ||
| <div class="description"><p>A business network card that is bound to a participant</p></div> | ||
| <div class="description"><p>A business network card that can connect to a business |
There was a problem hiding this comment.
Should this perhaps say A business network card that you can use in Playground to connect to a business network?
There was a problem hiding this comment.
no because you will be able to use cards on the command line soon
There was a problem hiding this comment.
we agreed to remove the in Playground bit :)
| <label class="radio-label" for="adminCard"><h3>Admin Card</h3></label> | ||
| <div class="description"><p>A business network card that is not bound to a participant.</p></div> | ||
| <div class="description"><p>A business network card that can install and start |
There was a problem hiding this comment.
ditto the above A business network card that can be used in Playground to install and start.....
There was a problem hiding this comment.
we agreed to remove the in Playground bit :)
| @@ -4,7 +4,7 @@ | |||
| <section class="profiles section"> | |||
| <div class="description upper"><b>Provide security credentials</b></div> | |||
| <div> | |||
| <p>You must provide one of two types of information to create an ID card:</p> | |||
| <p>You must provide one of two types of information to create a business network card:</p> | |||
There was a problem hiding this comment.
I wonder if this should be credential rather than information?
There was a problem hiding this comment.
yes i'll changes this
Updated identity issued to remove references to ID card Updated create card to better describe what admin and participant cards are for contributes to hyperledger/composer#2506 Signed-off-by: Caroline Church <caroline.church@uk.ibm.com>
cazfletch
force-pushed
the
id-card-references
branch
from
b45b478
to
9cf5e67
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated identity issued to remove references to ID card
Updated create card to better describe what admin and participant cards are for
contributes to hyperledger/composer#2506
Signed-off-by: Caroline Church caroline.church@uk.ibm.com