This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: cleanup messy code in pEx implementation #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Moopli
commented
Jun 8, 2023
Moopli
commented
- pEx implementation no longer needs to replace Credential ID temporarily
- assorted cleanup
vkubiv
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
+ Coverage 86.75% 86.77% +0.01%
==========================================
Files 355 355
Lines 48680 48713 +33
==========================================
+ Hits 42231 42269 +38
+ Misses 4886 4882 -4
+ Partials 1563 1562 -1
|
- pEx implementation no longer needs to replace Credential ID temporarily - assorted cleanup Signed-off-by: Filip Burlacu <Filip.Burlacu@gendigital.com>
Moopli
commented
Jun 12, 2023
| if !req.isLenApplicable(len(set[k])) { | ||
| for desc, cID := range set[k] { | ||
| exclude[desc+cID] = struct{}{} | ||
| for _, descriptors := range satisfiedDescriptors { |
There was a problem hiding this comment.
Something I noticed here: this code expects a single VC (and its BBS derived creds) to satisfy the correct number of input descriptors for a submission requirement that has nested submission requirements. As far as I know, this isn't quite right: the parent submission requirement should validate the number of satisfied nested submission requirements (not the number of input descriptors), and it shouldn't require that they be satisfied by a single credential.
Moopli
changed the title
rolsonquadras
approved these changes
Jun 12, 2023
sudeshrshetty
approved these changes
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.