This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Pull mathlib with support for 32-bit builds #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3595 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 355 355
Lines 48680 48680
=======================================
Hits 42231 42231
Misses 4886 4886
Partials 1563 1563 |
Moopli
approved these changes
Jun 2, 2023
Signed-off-by: Alessandro Sorniotti <aso@zurich.ibm.com>
sudeshrshetty
approved these changes
Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Pull mathlib with support for 32-bit builds
Description:
After the switch to mathlib, builds on 32-bit platforms failed, owing to the fact that mathlib was using a version of fabric-amcl which didn't include 32-bit implementations. Pulling the latest mathlib fixes the issue.
Summary:
We just update all the
go.modto refer to the latest mathlib.