This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
chore: Add options to VDR accept; update long-form logic #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 85.21% 78.94% -6.28%
==========================================
Files 34 16 -18
Lines 4112 1439 -2673
==========================================
- Hits 3504 1136 -2368
+ Misses 364 189 -175
+ Partials 244 114 -130 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Currently VDR makes decision on whether to accept or reject request based on method only. Add options to VDR Accept function so VDR can make more complex decisions (for example long-form VDR should reject request if number of parts in DID is not at least four) Closes hyperledger-archives#305 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
bstasyszyn
approved these changes
Dec 1, 2022
fqutishat
approved these changes
Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently VDR makes decision on whether to accept or reject request based on method only. Add options to VDR Accept function so VDR can make more complex decisions (for example long-form VDR should reject request if number of parts in DID is not at least four)
Closes #305
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com