This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: use different domain when anchor origin is down #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 85.40% 85.47% +0.07%
==========================================
Files 26 26
Lines 4076 4083 +7
==========================================
+ Hits 3481 3490 +9
Misses 352 352
+ Partials 243 241 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
force-pushed
the
update
branch
3 times, most recently
from
ccb35f4 to
9e31a21
Compare
bstasyszyn
approved these changes
Aug 9, 2022
component/vdr/orb/vdr.go
Outdated
| endpoint, err = v.discoveryService.GetEndpoint(docResolution.DocumentMetadata.Method.AnchorOrigin) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get endpoints: %w", err) | ||
| domain, errChoose := v.selectDomainSvc.Choose(v.domains) |
There was a problem hiding this comment.
Is it possible that the same domain will be chosen?
There was a problem hiding this comment.
Yes. I will add retry
sudeshrshetty
approved these changes
Aug 9, 2022
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Firas Qutishat firas.qutishat@securekey.com