fix(contracts): RateLimit minor changes
#4575
Conversation
aroralanuk
requested review from
yorhodes,
tkporter and
ltyu
as code owners
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4575 +/- ##
==========================================
- Coverage 82.33% 73.85% -8.48%
==========================================
Files 100 100
Lines 1421 1423 +2
Branches 180 181 +1
==========================================
- Hits 1170 1051 -119
- Misses 251 351 +100
- Partials 0 21 +21
|
| uint256 public refillRate; /// @notice Tokens per second refill rate | ||
| uint256 public lastUpdated; /// @notice Timestamp of the last time an action has been taken TODO prob can be uint40 | ||
| /// @notice Current filled level | ||
| uint256 public filledLevel; |
Check warning
Code scanning / Olympix Integrated Security
Some state variables are not being fuzzed in test functions, potentially leaving vulnerabilities unexplored. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/unfuzzed-variables Medium
| /// @notice Tokens per second refill rate | ||
| uint256 public refillRate; | ||
| /// @notice Timestamp of the last time an action has been taken TODO prob can be uint40 | ||
| uint256 public lastUpdated; |
Check warning
Code scanning / Olympix Integrated Security
Using uninitialized state variables may lead to unexpected behavior. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/uninitialized-state-variable Medium
| /// @notice Tokens per second refill rate | ||
| uint256 public refillRate; | ||
| /// @notice Timestamp of the last time an action has been taken TODO prob can be uint40 | ||
| uint256 public lastUpdated; |
Check warning
Code scanning / Olympix Integrated Security
Some state variables are not being fuzzed in test functions, potentially leaving vulnerabilities unexplored. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/unfuzzed-variables Medium
| /// @notice Current filled level | ||
| uint256 public filledLevel; | ||
| /// @notice Tokens per second refill rate | ||
| uint256 public refillRate; |
Check warning
Code scanning / Olympix Integrated Security
Using uninitialized state variables may lead to unexpected behavior. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/uninitialized-state-variable Medium
### Description - Added a check for invalid capacity and event for token level change ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/14 ### Backward compatibility Yes ### Testing Unit tests
### Description - Added a check for invalid capacity and event for token level change ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/14 ### Backward compatibility Yes ### Testing Unit tests
### Description - Added a check for invalid capacity and event for token level change ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/14 ### Backward compatibility Yes ### Testing Unit tests
### Description - Added a check for invalid capacity and event for token level change ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/14 ### Backward compatibility Yes ### Testing Unit tests
Description
Drive-by changes
None
Related issues
Backward compatibility
Yes
Testing
Unit tests