fix: add fix for checking for correct messageId in OPL2ToL1Ism and ArbL2ToL1Ism via external call
#4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f47590 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
==========================================
- Coverage 82.33% 73.76% -8.57%
==========================================
Files 100 100
Lines 1421 1422 +1
Branches 180 182 +2
==========================================
- Hits 1170 1049 -121
- Misses 251 352 +101
- Partials 0 21 +21
|
yorhodes
requested changes
Sep 11, 2024
aroralanuk
changed the base branch from
main
to
kunal/external-bridge-refactor
aroralanuk
changed the title
OPL2ToL1Ism via _verifyWithPortalCall() callOPL2ToL1Ism and ArbL2ToL1Ism via external call
yorhodes
approved these changes
Oct 9, 2024
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
…`ArbL2ToL1Ism` via external call (hyperlane-xyz#4437) ### Description - In agreement with Chainlight team's recommendation, added a second isVerified() check after portal call to make sure an arbitrary call which passes the check for metadata length and messageId cannot be verified without calling is verifyMessageId(messageId) in `OPL2ToL1Ism` and `ArbL2ToL1` ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/2 ### Backward compatibility No, but the contracts aren't deployed anywhere ### Testing Unit testing
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
…`ArbL2ToL1Ism` via external call (hyperlane-xyz#4437) ### Description - In agreement with Chainlight team's recommendation, added a second isVerified() check after portal call to make sure an arbitrary call which passes the check for metadata length and messageId cannot be verified without calling is verifyMessageId(messageId) in `OPL2ToL1Ism` and `ArbL2ToL1` ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/2 ### Backward compatibility No, but the contracts aren't deployed anywhere ### Testing Unit testing
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
…`ArbL2ToL1Ism` via external call (hyperlane-xyz#4437) ### Description - In agreement with Chainlight team's recommendation, added a second isVerified() check after portal call to make sure an arbitrary call which passes the check for metadata length and messageId cannot be verified without calling is verifyMessageId(messageId) in `OPL2ToL1Ism` and `ArbL2ToL1` ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/2 ### Backward compatibility No, but the contracts aren't deployed anywhere ### Testing Unit testing
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
…`ArbL2ToL1Ism` via external call (hyperlane-xyz#4437) ### Description - In agreement with Chainlight team's recommendation, added a second isVerified() check after portal call to make sure an arbitrary call which passes the check for metadata length and messageId cannot be verified without calling is verifyMessageId(messageId) in `OPL2ToL1Ism` and `ArbL2ToL1` ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/2 ### Backward compatibility No, but the contracts aren't deployed anywhere ### Testing Unit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OPL2ToL1IsmandArbL2ToL1Drive-by changes
None
Related issues
Backward compatibility
No, but the contracts aren't deployed anywhere
Testing
Unit testing