Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code spellcheck CI job #3467

Merged
merged 11 commits into from
Mar 26, 2024
Merged

Add code spellcheck CI job #3467

merged 11 commits into from
Mar 26, 2024

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Mar 21, 2024

Description

Fix spelling mistakes and create codespell CI job.
An extension of #3422 with the remaining mistakes fixed

Backward compatibility

Yes

miles-six and others added 2 commits March 21, 2024 11:14
Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: a43d113

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmrossy jmrossy enabled auto-merge (squash) March 21, 2024 15:43
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #3467 (a43d113) into main (7913d72) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3467   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         16      16           
=====================================
  Misses        16      16           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits

rust/hyperlane-core/src/traits/validator_announce.rs Outdated Show resolved Hide resolved
typescript/infra/src/utils/metrics.ts Outdated Show resolved Hide resolved
@jmrossy jmrossy disabled auto-merge March 25, 2024 20:55
@jmrossy jmrossy merged commit adab1be into main Mar 26, 2024
42 checks passed
@jmrossy jmrossy deleted the rossy/codespell branch March 26, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants