Add owner to Replica #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nambrot
reviewed
Jan 29, 2022
typescript/optics-tests/test/cross-chain/governanceRouter.test.ts
Outdated
Show resolved
Hide resolved
added 6 commits
January 28, 2022 20:18
yorhodes
pushed a commit
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
ownerstorage variable to Replica that is used to permission Replica updater rotations. It removes the concept of "benign" double updates in favor of updater rotation.Note that when the
owneris the null address, anyone can act as the owner. This allows the owner to be set post-facto (rather than in the initializer) so that existing Replicas can be upgraded.It is thus CRITICAL that when upgrading to this new implementation, their owners are set in the same transaction.
Note that the upgradability gap was not reduced in Replica, as it is in actuality one size smaller than it should have been. Effectively increasing the size of the upgradability gap is safe because no contracts are inheriting from Replica.
This PR also fully moves away from @optics-xyz/ts-interface and @optics-xyz/deploy in favor of optics-ts-interface and optics-deploy, respectively.