Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly store gas payment expenditure data in agent rocks db #2268

Merged
merged 4 commits into from
May 22, 2023
Merged

Conversation

asaj
Copy link
Contributor

@asaj asaj commented May 22, 2023

Description

This PR fixes a bug that resulted in gas payment expenditures not being properly stored in the rocks DB, making them unretrievable.

Drive-by changes

  • Introduces a macro to HyperlaneRocksDB to prevent similar bugs from happening in the future

@asaj asaj marked this pull request as ready for review May 22, 2023 18:57
@asaj asaj requested review from mattiekat and tkporter as code owners May 22, 2023 18:57
Copy link
Contributor

@mattiekat mattiekat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new macro for this, makes it a lot cleaner.

rust/hyperlane-base/src/db/rocks/hyperlane_db.rs Outdated Show resolved Hide resolved
@asaj asaj enabled auto-merge (squash) May 22, 2023 20:04
@asaj asaj merged commit 73fb967 into main May 22, 2023
@asaj asaj deleted the asaj/dbb branch May 22, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants