Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RoutingIsm #1985

Merged
merged 28 commits into from
Apr 18, 2023
Merged

Add RoutingIsm #1985

merged 28 commits into from
Apr 18, 2023

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Mar 22, 2023 •
edited
Loading

Description

This PR adds IRoutingIsm and three implementations:

  • AbstractRoutingIsm, which folks building RoutingIsms can inherit from
  • DomainRoutingIsm, which routes based on message origin
  • InterchainAccountIsm, which routes based on the ISM in the InterchainAccountMessage

Drive-by changes

  • Some related testing changes

Related issues

Backward compatibility

Are these changes backward compatible?

Yes

Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?

None

Testing

What kind of testing have these changes undergone?

Unit Tests

@asaj asaj marked this pull request as ready for review March 29, 2023 18:18
@asaj asaj requested a review from tkporter as a code owner March 29, 2023 18:18
@asaj asaj requested a review from yorhodes March 29, 2023 18:18
yorhodes
yorhodes reviewed Apr 7, 2023
View reviewed changes
solidity/contracts/isms/routing/AbstractRoutingIsm.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/routing/DomainRoutingIsm.sol Show resolved Hide resolved
solidity/contracts/isms/routing/DomainRoutingIsm.sol Show resolved Hide resolved
solidity/contracts/isms/routing/InterchainAccountIsm.sol Show resolved Hide resolved
solidity/contracts/isms/routing/DomainRoutingIsmFactory.sol Show resolved Hide resolved
solidity/contracts/mock/MockMailbox.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/routing/DomainRoutingIsm.sol Show resolved Hide resolved
solidity/contracts/mock/MockMailbox.sol Show resolved Hide resolved
solidity/test/InterchainAccountRouter.t.sol Show resolved Hide resolved
solidity/test/isms/IsmTestUtils.sol Show resolved Hide resolved
@asaj asaj requested a review from yorhodes April 12, 2023 22:07
yorhodes
yorhodes approved these changes Apr 18, 2023
View reviewed changes
solidity/contracts/mock/MockMailbox.sol Show resolved Hide resolved
solidity/test/isms/IsmTestUtils.sol Show resolved Hide resolved
@asaj asaj merged commit f8d645e into main Apr 18, 2023
@asaj asaj deleted the asaj/routing branch April 18, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build and test storage based routing ISM
2 participants
@asaj @yorhodes