Skip to content

Commit

Permalink
Misc. agent cleanup and dead code deletion (#470)
Browse files Browse the repository at this point in the history
* Fix path to agent::Agent in comment.

Otherwise `cargo doc` emits a rustdoc::broken_intra_doc_links warning.

* Use automatic link in comment for rustdoc.

Otherwise 'cargo doc' emits a warning.

* Delete checkpointer agent.

It is not used in current deployment.

* Delete kms-cli.

Not used in current deployment (no references).

* Include "--all" in precommit cargo fmt -- --check invocation.

* Delete unused and hidden src/bin programs.

These appear to have been introduced over a year ago and appear to be dead
code now.

Unhide them from vscode workspace too -- since they were hidden, automated
refactoring tools wouldn't find them until compiler failed.

* Update github CODEOWNERS to current Abacus team.

Drop optional authors field from Cargo.tomls.

* Drop processordb from .gitignore.

Processor crate has been deleted.

* Delete balance-exporter crate.

It is not used / no references.

* Hoist abacus-cli into its own top-level crate.

It is the only tool now, no reason to hide it inside
of a tools directory.

* Delete old relaese.sh, which only relates to Celo Optics.

* Cleanup top-level rust README.md.

-  Architecture paragraphs outdated, delete.
-  Point to run-locally.sh instead of documentation.

* Explain a bit more about crate deps in README.

* Dockerfile fix after tools directory restructuring.

We had previously hoisted abacus-cli out since it
was the only remaining tool.

* Fix path to agent::Agent in comment.

Otherwise `cargo doc` emits a rustdoc::broken_intra_doc_links warning.

* Use automatic link in coment for rustdoc.

Otherwise 'cargo doc' emits a warning.

* Delete checkpointer agent.

It is not used in current deployment.

* Delete kms-cli.

Not used in current deployment (no references).

* Include "--all" in precommit cargo fmt -- --check invocation.

* Delete unused and hidden src/bin programs.

These appear to have been introduced over a year ago and appear to be dead
code now.

Unhide them from vscode workspace too -- since they were hidden, automated
refactoring tools wouldn't find them until compiler failed.

* Update github CODEOWNERS to current Abacus team.

Drop optional authors field from Cargo.tomls.

* Drop processordb from .gitignore.

Processor crate has been deleted.

* Delete balance-exporter crate.

It is not used / no references.

* Hoist abacus-cli into its own top-level crate.

It is the only tool now, no reason to hide it inside
of a tools directory.

* Delete old relaese.sh, which only relates to Celo Optics.

* Cleanup top-level rust README.md.

-  Architecture paragraphs outdated, delete.
-  Point to run-locally.sh instead of documentation.

* Explain a bit more about crate deps in README.

* Dockerfile fix after tools directory restructuring.

We had previously hoisted abacus-cli out since it
was the only remaining tool.
  • Loading branch information
webbhorn authored May 26, 2022
1 parent 87ee40e commit 6b3822f
Show file tree
Hide file tree
Showing 38 changed files with 32 additions and 1,012 deletions.
3 changes: 1 addition & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
* @prestwich @anna-carroll @erinhales
rust/ @prestwich @emberian @ltchang
* @asaj @mattiecnvr @nambrot @tkporter @webbhorn @yorhodes @zmanian
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
with:
working-directory: ./rust
- name: Rustfmt
run: cargo fmt -- --check
run: cargo fmt --all -- --check
- name: Check
run: cargo check --all-features --all-targets --verbose
- name: Clippy
Expand Down
1 change: 0 additions & 1 deletion rust/.gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
target
processordb
validatordb
relayerdb
kathydb
1 change: 0 additions & 1 deletion rust/.vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"files.exclude": {
"target": true,
"**/bin": true,
},
}
219 changes: 12 additions & 207 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,10 @@ cargo-features = ["edition2021"]
members = [
"abacus-core",
"abacus-base",
"abacus-cli",
"abacus-test",
"chains/abacus-ethereum",
"agents/kathy",
"agents/checkpointer",
"agents/validator",
"agents/relayer",
"tools/kms-cli",
"tools/abacus-cli",
"tools/balance-exporter"
]
Loading

0 comments on commit 6b3822f

Please sign in to comment.